koord-descheduler: allow annotated pod only pass non-retriable filter#1321
Merged
koordinator-bot[bot] merged 1 commit intokoordinator-sh:mainfrom May 23, 2023
Merged
Conversation
Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1321 +/- ##
==========================================
- Coverage 64.75% 64.71% -0.04%
==========================================
Files 319 319
Lines 33244 33244
==========================================
- Hits 21527 21515 -12
- Misses 10145 10156 +11
- Partials 1572 1573 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
The user of podMigrationJob may know the risk of migrationPod. So we allow annotated job to pass filter. Then user can use annotation to indicate he/she knows the risk.
However, user just want the annotated job to pass non-retryable filter and the retryable-filter(flow-control ability) should remain unchanged.
Ⅱ. Does this pull request fix one issue?
None
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test